Skip to content

opal_tag should mirror the javascript_tag api #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2024
Merged

opal_tag should mirror the javascript_tag api #131

merged 4 commits into from
Dec 8, 2024

Conversation

@dscataglini
Copy link

@dscataglini dscataglini commented Jul 30, 2024 •
edited
Loading

Currently it's not possible to pass html_options to the javascript_tag.
So the following is not possible

opal_tag nonce: true do
  # some javascript
end

This PR fixes that and provides an identical api to javascript_tag so it behaves as you would think it would

@dscataglini dscataglini marked this pull request as draft July 30, 2024 18:46
@dscataglini dscataglini marked this pull request as ready for review August 1, 2024 17:28
@hmdne hmdne merged commit 15191e6 into opal:master Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrogers-hedgeye jrogers-hedgeye jrogers-hedgeye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dscataglini @jrogers-hedgeye @hmdne @hedgeye-diego