-
Notifications
You must be signed in to change notification settings - Fork 72
[Refactor] refactor mim install #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] refactor mim install #132
Conversation
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
===========================================
+ Coverage 32.77% 53.59% +20.81%
===========================================
Files 22 22
Lines 1620 1532 -88
Branches 371 328 -43
===========================================
+ Hits 531 821 +290
+ Misses 1045 585 -460
- Partials 44 126 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…flicts and add mminstall.txt cache
combine commit record: for ci debug
Co-authored-by: Zaida Zhou <[email protected]>
combine commit record: for ci debug
combine commit record: foc ci debug
combine commit: for ci debug
b72475a to
7c98032
Compare
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Refactor mim install for better user experience. Mainly include the following enhancements:
mim installin the same way you usepip install!Modification
1. commands/install.py
mim installjust likepip install.pip._internal.commands.create_commandto call pip for installation instead ofsubprocess.check_call. This allows us to hack the pip code.pip install.Distributionin pip makes mim extra requirements added when returning dependencies. If mim extra requirements do not exist, download the source distribution package of the corresponding version from PyPI, and extract and parse mminstall.txt as mim extra requirements.mim installno longer manually copies the required files to the.mimdirectory.2. tests/test_*.py
tests/test_install.py.mminstall.txthas not been included in the previously releasedmmclspackage,mmcv-fullcannot be installed automatically, so the steps to installmmcv-fullhave been added to several test files.mmclsintests/test_list.pysincemim installno longer creates the.mimfolder.BC-breaking (Optional)
mim install git+<vcs project url>instead.mim installwill not create and copy the required resource files to the.mimfolder for the OpenMMLab packages, because newer versions of OpenMMLab packages already package the.miminto the distribution, please use these newer versions.Use cases (Optional)
Already manually tested locally
mim install mmdet mmclsmim install -r requirements.txtmim install git+https://github.com/open-mmlab/mmdetection.gitmim install -e <path>mim install mmdet -i <url> -f <url>Checklist