Skip to content

Conversation

@hellock
Copy link
Member

@hellock hellock commented Dec 9, 2018

This PR solves #155. In fact, this repo can support PyTorch 1.0 without any changes. Only some minor changes are needed for mmcv.

We made some minor updates though.

  • Support half tensors (fp16) for roi_align and roi_pooling.
  • Remove some legacy code.

You need to use the pytorch-1.0 branch of mmcv with this PR. After the branch being merged, mmcv will be updated to v0.2.3.

The results are shown in the below table.

PyTorch 0.4.1 PyTorch 1.0.0
RPN 57.1 57.0
Faster R-CNN 36.4 36.5
Mask R-CNN 37.3 / 34.2 37.3 / 34.2
RetinaNet 35.6 35.7
Cascade R-CNN 40.3 40.4
Cascade Mask R-CNN 41.3/35.7 41.2/35.7

@hellock hellock changed the base branch from master to pytorch-1.0 December 10, 2018 09:36
@hellock hellock merged commit e9cb6fa into open-mmlab:pytorch-1.0 Dec 13, 2018
@adityaarun1
Copy link

@hellock How do one install mmcv>=0.2.2 ? The master branch on its github channel installs version 0.2.1

@hellock
Copy link
Member Author

hellock commented Dec 18, 2018

@adityaarun1 mmcv 0.2.2 is not released yet, you can checkout the pytorch-1.0 branch of mmcv to use it.

@zxt881108
Copy link

@hellock How about the training speed after updating pytorch 1.0?

@wangg12
Copy link
Contributor

wangg12 commented Dec 20, 2018

@hellock mmcv 0.2.2 has been released, is it ready to merge this into master?

@hellock
Copy link
Member Author

hellock commented Dec 20, 2018

Hi @wangg12 , recently released v0.2.2 is the version for PyTorch 1.0. If you'd like to use PyTorch 1.0, you can checkout to the pytorch-1.0 branch of mmcv, which may be released later as v0.2.3.

@hellock
Copy link
Member Author

hellock commented Dec 20, 2018

@zxt881108 Currently the speed of PyTorch 1.0 and 0.4.1 is similar since we made only minor changes, we will take time to optimize it.

JegernOUTT pushed a commit to JegernOUTT/mmdetection that referenced this pull request Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants