Skip to content

Conversation

@xvjiarui
Copy link
Collaborator

@xvjiarui xvjiarui commented Aug 5, 2020

This PR added metric_items option for COCO evaluation.
It also fixed #3468

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #3497 into master will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3497      +/-   ##
==========================================
- Coverage   58.79%   58.65%   -0.14%     
==========================================
  Files         205      205              
  Lines       13609    13621      +12     
  Branches     2302     2310       +8     
==========================================
- Hits         8002     7990      -12     
- Misses       5232     5255      +23     
- Partials      375      376       +1     
Flag Coverage Δ
#unittests 58.65% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/coco.py 11.60% <0.00%> (-0.50%) ⬇️
mmdet/models/roi_heads/mask_scoring_roi_head.py 81.57% <0.00%> (-18.43%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 92.30% <0.00%> (-5.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bbfb7...e20c5c2. Read the comment docs.

.5, 0.95, int(np.round((0.95 - .5) / .05)) + 1, endpoint=True)
if metric_items is not None:
if not isinstance(metric_items, list):
metric_items = [metric_items]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better add assert isinstance(metric_items, str)

@hellock hellock merged commit 68d860d into open-mmlab:master Aug 6, 2020
@zhjw0927
Copy link

I'm still not sure how to use it?
If I evaluate bbox in coco, run python3 tool/test.py configs/**.py work_dirs/**.pth --eval bbox
then?

@xvjiarui
Copy link
Collaborator Author

xvjiarui commented Aug 24, 2020

If you would like to specify metric_items, you may pass in --eval-options metric_items=mAP_50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mAP@75 returns -1.

4 participants