[Fix] Change self.loss_decode back to dict in Single Loss situation.
#1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
==========================================
- Coverage 89.85% 89.75% -0.11%
==========================================
Files 118 118
Lines 6558 6578 +20
Branches 1019 1024 +5
==========================================
+ Hits 5893 5904 +11
- Misses 464 473 +9
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Johnson-Wang
approved these changes
Oct 29, 2021
Junjun2016
reviewed
Oct 29, 2021
Junjun2016
reviewed
Oct 29, 2021
Junjun2016
approved these changes
Nov 1, 2021
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
…on. (open-mmlab#1002) * fix single loss type * fix error in ohem & point_head * fix coverage miss * fix uncoverage error of PointHead loss * fix coverage miss * fix uncoverage error of PointHead loss * nn.modules.container.ModuleList to nn.ModuleList * more simple format * merge unittest def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous version of MMSegmentation, the
loss_decodeis a dict.When using multiple losses pipeline, it is changed to
nn.ModuleList()where each loss would be appended. It would raise BC-Breaking problem.Thus, we change it back to dict of single loss situation.