Skip to content

[Fix] Fix symlink failure on Windows #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2021
Merged

[Fix] Fix symlink failure on Windows #1038

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52cd3ac
fix symlink failure on Windows
Junjun2016 Nov 14, 2021
ccfc6fc
Merge branch 'master' of https://github.com/open-mmlab/mmsegmentation…
Junjun2016 Nov 14, 2021
dd6a78e
fix develop mode on windows
Junjun2016 Nov 25, 2021
468d32a
Merge branch 'master' of https://github.com/open-mmlab/mmsegmentation…
Junjun2016 Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright (c) OpenMMLab. All rights reserved.
import os
import os.path as osp
import platform
import shutil
import sys
import warnings
Expand Down Expand Up @@ -109,10 +110,16 @@ def add_mim_extension():
# parse installment mode
if 'develop' in sys.argv:
# installed by `pip install -e .`
mode = 'symlink'
elif 'sdist' in sys.argv or 'bdist_wheel' in sys.argv:
if platform.system() == 'Windows':
# set `copy` mode here since symlink fails on Windows.
mode = 'copy'
else:
mode = 'symlink'
elif 'sdist' in sys.argv or 'bdist_wheel' in sys.argv or \
platform.system() == 'Windows':
# installed by `pip install .`
# or create source distribution by `python setup.py sdist`
# set `copy` mode here since symlink fails with WinError on Windows.
mode = 'copy'
else:
return
Expand Down