Skip to content

Conversation

@sungchul2
Copy link

Motivation

According to #1445, evaluation part should be changed, too.

Modification

Record the initial label with .clone(), because label is torch.tensor.

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2022

CLA assistant check
All committers have signed the CLA.

@sungchul2 sungchul2 changed the title fix fix bug about label_map in evaluation part Sep 15, 2022
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix, it looks good to me. Please sign CLA first

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 89.11% // Head: 89.11% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (23a4042) compared to base (31395a8).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2075   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         145      145           
  Lines        8715     8716    +1     
  Branches     1471     1471           
=======================================
+ Hits         7766     7767    +1     
  Misses        707      707           
  Partials      242      242           
Flag Coverage Δ
unittests 89.11% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/core/evaluation/metrics.py 93.68% <50.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit ee25adc into open-mmlab:master Sep 15, 2022
@sungchul2 sungchul2 deleted the fix_label_map_eval branch September 15, 2022 13:48
@sungchul2 sungchul2 restored the fix_label_map_eval branch September 16, 2022 00:49
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
…ag (open-mmlab#2075)

* Update textual_inversion_flax.py

* Update textual_inversion_flax.py

* Typo

sorry.

* Format source
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants