Skip to content

Conversation

@xiexinch
Copy link
Collaborator

@xiexinch xiexinch commented Mar 2, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6d63e77) 83.73% compared to head (6a6cb1b) 83.73%.

❗ Current head 6a6cb1b differs from pull request most recent head 237ac91. Consider uploading reports for the commit 237ac91 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2667   +/-   ##
========================================
  Coverage    83.73%   83.73%           
========================================
  Files          156      156           
  Lines         9333     9333           
  Branches      1367     1367           
========================================
  Hits          7815     7815           
  Misses        1275     1275           
  Partials       243      243           
Flag Coverage Δ
unittests 83.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit f6de1aa into open-mmlab:dev-1.x Mar 17, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants