[Enhancement] Change assertion logic inference cfg.model.test_cfg #3012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xiexinch
reviewed
May 17, 2023
Comment on lines
329
to
332
| if isinstance(self.test_cfg.mode, dict): | ||
| assert self.test_cfg['mode'] in ['slide', 'whole'] | ||
| else: | ||
| assert self.test_cfg.mode in ['slide', 'whole'] |
Collaborator
There was a problem hiding this comment.
How about convert the self.test_cfg to mmengine.Config at the init function?
class EncoderDecoder:
def __init__(...):
...
self.test_cfg = Config(test_cfg)
...
xiexinch
changed the title
xiexinch
approved these changes
Jun 16, 2023
…rt_error_cfg.model.test_cfg
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
…en-mmlab#3012) ## Motivation In encode_decoder.py , assertion logic is not working correctly if user modifes cfg.test_cfg and defines it in a dictionary format. See: open-mmlab#3011 ## Modification Slight change to assertion behaviour to change assertion depending on if received test_cfg object is a dict or not. ## BC-breaking (Optional) Unsure - I believe this will not break any downstream tasks as the previous logic is still included ## Use cases (Optional) n/a --------- Co-authored-by: xiexinch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In encode_decoder.py , assertion logic is not working correctly if user modifes cfg.test_cfg and defines it in a dictionary format. See: #3011
Modification
Slight change to assertion behaviour to change assertion depending on if received test_cfg object is a dict or not.
BC-breaking (Optional)
Unsure - I believe this will not break any downstream tasks as the previous logic is still included
Use cases (Optional)
n/a