Assumption that `EOF` is enclosed in parantheses (example: `(-1)`); otherwise compilation error

[JayFoxRox]

Previously discussed at DevSolar/pdclib#20 (comment).

These 2 problems exist in jsoncpp:

1. EOF is used in a way that might break certain C implementations (in our case, pdclib for C + libcxx for C++, with clang as compiler). The code assumes that EOF will provide paranetheses for dynamic_cast:
   

   jsoncpp/src/lib_json/json_reader.cpp

   Line 108 in 94cda30

   std::getline(is, doc, static_cast<char> EOF);

2. EOF isn't a char, but it's used as if it is. EOF is also not very strictly defined, so the behavior will be C implementation defined. Typically you get either a char (cast to int) or an EOF (int) as return value from functions like getchar().

Point 1 is easily fixed, but 2 shows that it might not be necessary to fix it - the problematic code needs to be rewritten.

[BillyDonahue]

that's quite bad. static_casr<char>(EOF) is a nonsense expression.

On Thu, Apr 22, 2021 at 7:13 AM Jannik Vogel ***@***.***> wrote: Previously discussed at DevSolar/pdclib#20 (comment) <DevSolar/pdclib#20 (comment)>. These 2 problems exist in jsoncpp: 1. EOF is used in a way that might break certain C implementations (in our case, pdclib for C + libcxx for C++, with clang as compiler). The code assumes that EOF will provide paranetheses for dynamic_cast: https://github.com/open-source-parsers/jsoncpp/blob/94cda30dbddc1859f111848fdd05dfb85d3287c7/src/lib_json/json_reader.cpp#L108 2. EOF isn't a char, but it's used as if it is. EOF is also not very strictly defined, so the behavior will be C implementation defined. Typically you get either a char (cast to int) *or* an EOF (int) as return value from functions like getchar(). Point 1 is easily fixed, but 2 shows that it might not be necessary to fix it - the problematic code needs to be rewritten. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1288>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBWORB2C74DRUBNXAQF7YDTKAAEXANCNFSM43MHR6PQ> .

-- ǝnɥɐuop ʎllıq

[cdunn2001]

Hmm. I guess getline(stream, EOF) was my own mistake from many years ago, in 56a1d6c .

I guess we want this:

std::string s(std::istreambuf_iterator<char>(stream), {});