Skip to content

Examples build is broken in Windows DLL build #3439

Closed
@ThomsonTan

Description

@ThomsonTan

It seems the PR #3421 change target_link_libraries(common_foo_library PUBLIC opentelemetry_api) to target_link_libraries(common_foo_library PRIVATE opentelemetry-cpp::api), but the dependency should be PUBLIC because the compile definitions on opentelemtry-cpp::api target (like OPENTELEMETRY_STL_VERSION) should be propagated from API to the final executable target which configures the SDK, or the API header file will be inconsistent in the executable and the common library.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions