core(rollout): extract rollout module, add listing API, and return file heads #1634

aibrahim-oai · 2025-07-21T02:48:40Z

Move rollout persistence and listing into a dedicated module: rollout/{recorder,list}.
Expose lightweight conversation listing that returns file paths plus the first 5 JSONL records for preview.

dylan-hurd-oai · 2025-07-21T03:08:31Z

codex-rs/core/src/session_manager.rs

+/// Directory layout: `~/.codex/sessions/YYYY/MM/DD/rollout-YYYY-MM-DDThh-mm-ss-<uuid>.jsonl`
+/// The first JSONL line is a `SessionMeta` object; subsequent lines are response/state records.
+///
+/// Returned structure (earliest first):


Do we want to reverse this? i.e. latest first

dylan-hurd-oai · 2025-07-21T03:13:10Z

codex-rs/core/src/session_manager.rs

+                    .and_then(|s| s.parse::<u8>().ok())
+                    .map(|m| (m, e.path()))
+            })
+            .collect();


This logic is repeated a few times, do we want to refactor it into a helper function?

dylan-hurd-oai · 2025-07-21T03:20:48Z

codex-rs/core/src/session_manager.rs

+/// Returned page of sessions.
+#[derive(Debug)]
+pub struct SessionsPage {
+    pub sessions: Vec<Value>,


Curious why we're using Value here instead of parsing the session files into SavedSession objects?

That's great idea. My PR is just too big. Maybe in the next PR I can do that. I don't see a problem now in returning the value because jsonl is a bunch of json objects.

dylan-hurd-oai

LGTM - reasonable to follow up on the SavedSession change in a subsequent PR

pakrym-oai · 2025-07-21T14:50:37Z

codex-rs/core/src/session_manager.rs

+/// The first JSONL line is a `SessionMeta` object; subsequent lines are response/state records.
+///
+/// Returned structure (latest (newest) first):
+fn traverse_directories(


I'm not sure the complexity of pagination/filtering is worth it here.

We can easily list 1000 sessions in one page and I doubt users ever care about more than 10 last sessions.

That's right, but I think it wouldn't hurt to have, right? what if we want to construct a memory or sth that requires looking at a lot of sessions.

pakrym-oai · 2025-07-21T14:51:55Z

codex-rs/core/src/session_manager.rs

+        .to_string();
+
+    match mode {
+        SessionsMode::Full => {


Who is using SessionsMode::Full?

The client when loading one session.

github-actions · 2025-07-21T17:19:44Z

Summary

Adds a new session_manager module that lists on-disk rollout sessions with pagination, date-range and ID filtering, and “full / lite” payload modes.
get_sessions, SessionsMode, and SessionsPage are exported; tests and minor tweaks to Cargo.toml, lib.rs, and rollout.rs complete the integration.

Review

Nice addition—clean directory traversal, clear filtering logic, and thorough unit tests.
A few tiny nits for polish:

Consider making MAX_SCAN_FILES configurable or at least documenting the rationale.
spawn_blocking error is wrapped with io::Error::other; a dedicated error enum could give callers finer insight.
collect_* silently ignores parse errors; a debug log might help during triage.
In Lite mode the head/tail constants could be parameters to avoid magic numbers.

Overall, the feature is well-structured and ready to merge after any minor tweaks you deem worthwhile.

View workflow run

gpeal · 2025-07-29T23:43:40Z

codex-rs/core/src/session_manager.rs

+    page_size: usize,
+    cursor: Option<&str>,
+) -> io::Result<ConversationsPage> {
+    if page_size == 0 {


Is special casing this? I think page_size == 0 should "just work" and it's not worth optimizing this case since it's not useful from the caller's perspective

gpeal · 2025-07-29T23:44:48Z

codex-rs/core/src/session_manager.rs

+/// Pagination cursor token format: "<file_ts>|<uuid>" where `file_ts` matches the
+/// filename timestamp portion (YYYY-MM-DDThh-mm-ss) used in rollout filenames.
+/// The cursor orders files by timestamp desc, then UUID desc.
+fn parse_cursor_token(token: &str) -> Option<(OffsetDateTime, Uuid)> {


Suggested change

fn parse_cursor_token(token: &str) -> Option<(OffsetDateTime, Uuid)> {

fn parse_cursor(cursor: &str) -> Option<(OffsetDateTime, Uuid)> {

gpeal · 2025-07-29T23:47:06Z

codex-rs/core/src/session_manager.rs

+fn parse_timestamp_uuid_from_filename(name: &str) -> Option<(OffsetDateTime, Uuid)> {
+    // Format: rollout-YYYY-MM-DDThh-mm-ss-<uuid>.jsonl
+    let core = name.strip_prefix("rollout-")?.strip_suffix(".jsonl")?;
+    if core.len() < 37 {
+        return None;
+    } // need at least dt + '-' + 36
+    let uuid_part = &core[core.len() - 36..];
+    let dt_part = &core[..core.len() - 37]; // strip trailing '-' before uuid
+    let Ok(uuid) = Uuid::parse_str(uuid_part) else {
+        return None;
+    };
+    let format: &[FormatItem] =
+        format_description!("[year]-[month]-[day]T[hour]-[minute]-[second]");
+    let ts = PrimitiveDateTime::parse(dt_part, format).ok()?.assume_utc();
+    Some((ts, uuid))
+}


Does this work? It doesn't rely on hard coding offsets

use time::{OffsetDateTime, PrimitiveDateTime, macros::format_description}; use uuid::Uuid; fn parse_timestamp_uuid_from_filename(name: &str) -> Option<(OffsetDateTime, Uuid)> { // Expected: rollout-YYYY-MM-DDThh-mm-ss-<uuid>.jsonl let core = name.strip_prefix("rollout-")?.strip_suffix(".jsonl")?; // Split at the last '-' so the timestamp (which contains '-') stays intact. let (ts_str, uuid_str) = core.rsplit_once('-')?; let uuid = Uuid::parse_str(uuid_str).ok()?; let fmt = format_description!("[year]-[month]-[day]T[hour]-[minute]-[second]"); let ts = PrimitiveDateTime::parse(ts_str, fmt).ok()?.assume_utc(); Some((ts, uuid)) }

The uuid has - in them. However, I did something less card coded. have a look.

gpeal · 2025-07-29T23:48:10Z

codex-rs/core/src/session_manager.rs

+    Ok(vec)
+}
+
+// Helper: collect files in `parent`, parse with `parse(name_str, path)` into arbitrary value.


Suggested change

// Helper: collect files in `parent`, parse with `parse(name_str, path)` into arbitrary value.

// Collects files in a directory and parses them with `parse`.

gpeal · 2025-07-30T00:10:09Z

codex-rs/core/src/session_manager.rs

+    let (anchor_ts, anchor_id) =
+        anchor.unwrap_or_else(|| (OffsetDateTime::UNIX_EPOCH, Uuid::nil()));
+
+    let year_dirs = collect_dirs_desc(&root, |s| s.parse::<i32>().ok())?;


Suggested change

let year_dirs = collect_dirs_desc(&root, |s| s.parse::<i32>().ok())?;

let year_dirs = collect_dirs_desc(&root, |s| s.parse::<u16>().ok())?;

Does this work

gpeal · 2025-07-30T00:10:35Z

codex-rs/core/src/session_manager.rs

+    ))
+}
+
+// Helper: collect immediate subdirectories of `parent`, parse their (string) names with `parse`,


Suggested change

// Helper: collect immediate subdirectories of `parent`, parse their (string) names with `parse`,

/// Collect immediate subdirectories of `parent`, parse their (string) names with `parse`,

aibrahim-oai · 2025-09-03T00:29:37Z

@codex review this in detail.

chatgpt-codex-connector · 2025-09-03T00:29:44Z

You have reached your rate limits for code reviews, please try again later

aibrahim-oai · 2025-09-03T00:33:48Z

@codex review this in detail.

chatgpt-codex-connector · 2025-09-03T00:33:54Z

You have reached your rate limits for code reviews, please try again later

htplz7l5 · 2025-09-03T04:00:24Z

codex-rs/core/src/rollout/list.rs

+
+/// Load conversation file paths from disk using directory traversal.
+///
+/// Directory layout: `~/.codex/sessions/YYYY/MM/DD/rollout-YYYY-MM-DDThh-mm-ss-<uuid>.jsonl`


maybe use just a uuid v7? and you won't need YYYYMMDDs.

…pagination test; document API fields

…ts and re-exports

…}; update traversal and tests

…r::list_conversations; move listing here and re-export APIs; remove session_manager

…and remove from mod

….rs)

…olution

aibrahim-oai · 2025-09-03T19:14:53Z

Work in progress for this issue: #2080

aibrahim-oai requested review from bolinfest, gpeal, dylan-hurd-oai and pakrym-oai July 21, 2025 02:58

dylan-hurd-oai reviewed Jul 21, 2025

View reviewed changes

dylan-hurd-oai approved these changes Jul 21, 2025

View reviewed changes

pakrym-oai reviewed Jul 21, 2025

View reviewed changes

aibrahim-oai added the codex-review label Jul 21, 2025

github-actions bot added codex-review-in-progress and removed codex-review labels Jul 21, 2025

github-actions bot added codex-review-completed and removed codex-review-in-progress labels Jul 21, 2025

aibrahim-oai marked this pull request as draft July 27, 2025 19:55

aibrahim-oai marked this pull request as ready for review July 29, 2025 22:10

gpeal reviewed Jul 30, 2025

View reviewed changes

aibrahim-oai requested review from gpeal and dylan-hurd-oai August 4, 2025 23:04

aibrahim-oai marked this pull request as draft August 13, 2025 20:02

aibrahim-oai force-pushed the get_sessions branch from 4f29301 to 88656cd Compare September 2, 2025 23:03

aibrahim-oai marked this pull request as ready for review September 2, 2025 23:16

aibrahim-oai changed the title ~~Core: initialize session manager to search for session data.~~ core(rollout): extract rollout module, add listing API, and return file heads Sep 3, 2025

htplz7l5 reviewed Sep 3, 2025

View reviewed changes

aibrahim-oai added 24 commits September 3, 2025 00:29

core: stabilize session ordering by (timestamp desc, uuid desc); add …

e81d82d

…pagination test; document API fields

review

24c073a

fmt

3d29258

core: get_conversations takes codex_home Path, not Config; update tes…

3a10d30

…ts and re-exports

core: ConversationsPage now returns items { path, head:first 5 JSONL …

f5cd87e

…}; update traversal and tests

fix

1f99827

core(rollout): split into rollout/{recorder,list}, add RolloutRecorde…

9f1c103

…r::list_conversations; move listing here and re-export APIs; remove session_manager

rollout

cf260c6

rollout

1a9f000

tests(core): rename session_manager tests to rollout.rs

515982a

core(rollout): move list_conversations into rollout/recorder.rs impl …

a67e308

…and remove from mod

refactor

8a92a68

refactor

6f3b709

refactor

a175624

tests(rollout): move rollout listing tests into module (rollout/tests…

bcdefc9

….rs)

fix(rollout): export tests module to satisfy rust-analyzer module res…

d325b77

…olution

refactor

2870b81

review

fbbb6f3

review

6ef0325

clippy

6b13e2d

clippy

06aafd2

clippy

63aa2b4

clippy

7a01ec9

clippy

7733155

aibrahim-oai force-pushed the get_sessions branch from 9ce793e to 7733155 Compare September 3, 2025 07:31

aibrahim-oai enabled auto-merge (squash) September 3, 2025 07:31

aibrahim-oai merged commit d77b33d into main Sep 3, 2025
18 checks passed

aibrahim-oai deleted the get_sessions branch September 3, 2025 07:39

github-actions bot locked and limited conversation to collaborators Sep 3, 2025

	fn parse_cursor_token(token: &str) -> Option<(OffsetDateTime, Uuid)> {
	fn parse_cursor(cursor: &str) -> Option<(OffsetDateTime, Uuid)> {

	// Helper: collect files in `parent`, parse with `parse(name_str, path)` into arbitrary value.
	// Collects files in a directory and parses them with `parse`.

	let year_dirs = collect_dirs_desc(&root, \|s\| s.parse::<i32>().ok())?;
	let year_dirs = collect_dirs_desc(&root, \|s\| s.parse::<u16>().ok())?;

	// Helper: collect immediate subdirectories of `parent`, parse their (string) names with `parse`,
	/// Collect immediate subdirectories of `parent`, parse their (string) names with `parse`,

core(rollout): extract rollout module, add listing API, and return file heads #1634

core(rollout): extract rollout module, add listing API, and return file heads #1634

Uh oh!

Conversation

aibrahim-oai commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dylan-hurd-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai commented Sep 3, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 3, 2025

Uh oh!

aibrahim-oai commented Sep 3, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aibrahim-oai commented Sep 3, 2025

Uh oh!

Uh oh!

aibrahim-oai commented Jul 21, 2025 •

edited

Loading

aibrahim-oai Jul 21, 2025 •

edited

Loading