Re-add markdown streaming #2029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easong-openai
force-pushed
the
re-add-markdown
branch
from
5e885c2 to
ba3f13f
Compare
…t! for boolean checks with formatted messages\n- Avoid false positive by anchoring truncated phrase at line start\n- Accept >=1 'codex' header per turn (multiple answer blocks possible)
easong-openai
force-pushed
the
re-add-markdown
branch
from
925f414 to
3b554c4
Compare
pakrym-oai
reviewed
Aug 12, 2025
| }; | ||
| sess.tx_event.send(event).await.ok(); | ||
| } | ||
| ResponseEvent::ReasoningSummaryPartAdded => { |
There was a problem hiding this comment.
Do we need this because we get multiple reasoning sections is a row?
There was a problem hiding this comment.
Or just because we don't want to track content_part -> Thinking transition?
There was a problem hiding this comment.
We need a way to affirmatively break between different parts of the summary presently so that we can make sure they get newlines. I also want it so that we can just show thinking headers in the UI, similar to how we show a summarized command view - this will be important for the next part of the UI overhaul.
pakrym-oai
reviewed
Aug 12, 2025
| loop { | ||
| let ev = timeout(wait_time, codex.next_event()) | ||
| // Allow a bit more time to accommodate async startup work (e.g. config IO, tool discovery) | ||
| let ev = timeout(wait_time.max(Duration::from_secs(5)), codex.next_event()) |
There was a problem hiding this comment.
should we up the default above?
|
core lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for newlines, then render markdown on a line by line basis. Word wrap it for the current terminal size and then spit it out line by line into the UI. Also adds a bunch of tests and fixes some UI regressions.