Show progress indicator for /diff command #2245
Merged
+89
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
approved these changes
Aug 13, 2025
bolinfest
requested changes
Aug 13, 2025
codex-rs/tui/src/app.rs
Outdated
| } | ||
|
|
||
| let tx = self.app_event_tx.clone(); | ||
| thread::spawn(move || { |
There was a problem hiding this comment.
We can tokio::spawn() and make get_git_diff() async then, right?
…github.com/openai/codex into codex/show-working-state-for-/diff-command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DiffResultapp event and dispatch git diff asynchronouslyTesting
just fmtjust fix(fails:letexpressions in this position are unstable)cargo test --all-features(fails:letexpressions in this position are unstable)https://chatgpt.com/codex/tasks/task_i_689a839f32b88321840a893551d5fbef