Bridge command generation to powershell when on Windows #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
bolinfest
reviewed
Aug 14, 2025
eddy-win
force-pushed
the
eddy-oai/powershell-command
branch
from
b694b04 to
22e29cc
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
eddy-win
force-pushed
the
eddy-oai/powershell-command
branch
4 times, most recently
from
e56de43 to
9a957d1
Compare
bolinfest
approved these changes
Aug 19, 2025
| let first = command.first().map(String::as_str); | ||
| if first != Some(ps.exe.as_str()) { | ||
| // TODO (CODEX_2900): Handle escaping newlines. | ||
| if command.iter().any(|a| a.contains('\n') || a.contains('\r')) { |
There was a problem hiding this comment.
This seems a bit dicey?
There was a problem hiding this comment.
Yes, flagged CODEX-2900 for follow-up
| return Some(command); | ||
| } | ||
|
|
||
| let joined = shlex::try_join(command.iter().map(|s| s.as_str())).ok(); |
There was a problem hiding this comment.
Is shlex's quoting rules appropriate for Windows?
There was a problem hiding this comment.
It is not the best, flagged in CODEX-2900 for follow-up
| use tokio::process::Command; | ||
|
|
||
| // Prefer PowerShell 7+ (`pwsh`) if available, otherwise fall back to Windows PowerShell. | ||
| let has_pwsh = Command::new("pwsh") |
There was a problem hiding this comment.
Consider tokio::join! to run these in parallel since this is on the startup path via Session::new()?
eddy-win
force-pushed
the
eddy-oai/powershell-command
branch
from
9a957d1 to
84cee01
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why? How?
Testing