tui: skip identical consecutive entries in local composer history #2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid recording a local submission if it matches the previous entry - Add unit test to cover duplicate-skip behavior Note: no changes to persistent history; only local history is deduped.
easong-openai
approved these changes
Aug 15, 2025
|
Seems fine to me, but was there a specific bug you were seeing? |
|
yeah, maybe this is only something i see when testing codex itself but pressing up+enter a bunch of times results in having duplicate history entries, so next time you want to find something in your history you have to up-up-up-up-up past all the duplicates, but nothing changes in the textarea (since they're all the same text) so it kind of looks like history isn't working. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids inserting duplicate consecutive messages into the Chat Composer's local history.