-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Added new auth-related methods and events to mcp server #2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ent notification to the MCP server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments
to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request that is ready for review, or mark a draft as ready for review. You can also ask for a review by commenting "@codex review".
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
…import it, rather than the other way around.
@bolinfest, ready for another round of review. I incorporated feedback from your last round:
|
@bolinfest, I incorporated your latest round of feedback. The serialization code is now much simpler and cleaner! The key was to use the serde I think it's ready for another (hopefully final) round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, but please address comments before submitting!
This PR adds the following:
preferred_auth_method
value in the config.auth.json
file — the same behavior in the cli's/logout
command.authStatusChange
event notification that is sent when the auth status changes due to successful login or logout operations.codex mcp -c preferred_auth_method=apikey
.