core: write explicit [projects] tables for trusted projects #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid inline TOML tables for per-project entries - Ensure explicit table headers for [projects] and each project key - Add unit test to verify formatting (no inline tables)
dylan-hurd-oai
approved these changes
Aug 20, 2025
codex-rs/core/src/config.rs
Outdated
| )); | ||
| }; | ||
| // Ensure we emit an explicit [projects] header | ||
| projects_tbl.set_implicit(false); |
There was a problem hiding this comment.
Does toml require us to have [projects] to set [projects."/path/to/project"]? We parse [mcp_servers.playwright] and [profiles.oss] without [mcp_servers] or [profiles], respectively. Or is this just required to ensure the sub-tables are not in-line?
There was a problem hiding this comment.
hm yeah it's probably not required.
bolinfest
reviewed
Aug 21, 2025
| // Run the function; it should convert to explicit tables and set trusted | ||
| set_project_trusted(codex_home.path(), project_dir.path())?; | ||
|
|
||
| let contents = std::fs::read_to_string(&config_path)?; |
There was a problem hiding this comment.
Is there a reason why we cannot assert_eq!() on contents? What is variable in this point of the test?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all of my trust_level settings in my ~/.codex/config.toml were on one line.