Skip to content

Conversation

nornagon-openai
Copy link
Collaborator

@nornagon-openai nornagon-openai commented Sep 3, 2025

Summary

  • Emit a “Proposed Command” history cell when an ExecApprovalRequest arrives (parity with proposed patches).
  • Simplify the approval dialog: show only the reason/instructions; move the command preview into history.
  • Make approval/abort decision history concise:
    • Single line snippet; if multiline, show first line + " ...".
    • Truncate to 80 graphemes with ellipsis for very long commands.

Details

  • History
    • Add new_proposed_command to render a header and indented command preview.
    • Use shared prefix_lines helper for first/subsequent line prefixes.
  • Approval UI
    • UserApprovalWidget no longer renders the command in the modal; shows optional reason text only.
    • Decision history renders an inline, dimmed snippet per rules above.
  • Tests (snapshot-based)
    • Proposed/decision flow for short command.
    • Proposed multi-line + aborted decision snippet with “ ...”.
    • Very long one-line command -> truncated snippet with “…”.
    • Updated existing exec approval snapshots and test reasons.
Screenshot 2025-09-03 at 11 57 35 AM

after approving:

Screenshot 2025-09-03 at 11 58 18 AM

rejection:

Screenshot 2025-09-03 at 11 58 45 AM

big command:

Screen.Recording.2025-09-03.at.12.04.27.PM.mov

…og; concise decision snippets; add snapshot tests and update reasons
@nornagon-openai nornagon-openai changed the title TUI: render proposed exec commands in history; simplify approval dialog; concise decision snippets tui: fix approval dialog for large commands Sep 3, 2025
@nornagon-openai nornagon-openai marked this pull request as draft September 3, 2025 05:02
@nornagon-openai nornagon-openai marked this pull request as ready for review September 4, 2025 21:06
@nornagon-openai nornagon-openai enabled auto-merge (squash) September 4, 2025 23:38
@nornagon-openai nornagon-openai merged commit 742feaf into main Sep 4, 2025
18 checks passed
@nornagon-openai nornagon-openai deleted the nornagon/big-command branch September 4, 2025 23:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants