feat: POSIX unification and snapshot sessions #3179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
reviewed
Sep 4, 2025
Co-authored-by: Michael Bolin <[email protected]>
…f-oai/macos-snapshots
# Conflicts: # codex-rs/core/src/shell.rs
jif-oai
changed the title
bolinfest
requested changes
Sep 5, 2025
jif-oai
changed the title
bolinfest
approved these changes
Sep 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session snapshot
For POSIX shell, the goal is to take a snapshot of the interactive shell environment, store it in a session file located in
.codex/and only source this file for every command that is run.As a result, if a snapshot files exist,
bash -lc <CALL>get replaced bybash -c <CALL>.This also fixes the issue that
bash -lcdoes not source.bashrc, resulting in missing env variables and aliases in the codex session.POSIX unification
Unify
bashandzshshell into a POSIX shell. The rational is that the tool will not use anyzshspecific capabilities.