ZSH on UNIX system and better detection #3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
reviewed
Sep 4, 2025
bolinfest
approved these changes
Sep 5, 2025
| } | ||
| _ => Shell::Unknown, | ||
| } | ||
| Shell::Unknown |
There was a problem hiding this comment.
Perhaps we should default to /bin/sh on UNIX? That is required to be defined as per POSIX, I think? (Though it could point to anything...)
There was a problem hiding this comment.
For the record: No because POSIX does not guarantee -l to be defined on /bin/sh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bashshellszshon UNIX systemGlobally, reduce the specificity of MacOS code by considering it as a UNIX system for shell detection