feat(core): re-export InitialHistory from conversation_manager #3270
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M4n5ter <[email protected]>
bolinfest
approved these changes
Sep 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a re-export for InitialHistory from the internal conversation_manager module in codex-core's lib.rs.
The
RolloutRecorder::get_rollout_historymethod (exposed viapub use rollout::RolloutRecorder;, already present in lib.rs) returns anInitialHistorytype, which is defined in the private conversation_manager module. Without this re-export, consumers of the public RolloutRecorder API would not be able to directly use the return type, as they cannot access the private module. This would result in an inconvenient experience where the method's return value cannot be handled without additional, non-obvious imports.By adding
pub use conversation_manager::InitialHistory;, we make InitialHistory available ascodex_core::InitialHistory, improving API ergonomics for users of the rollout functionality while keeping the conversation_manager module internal.No functional changes are made; this is a pure re-export for better usability.