-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Unified execution #3288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Unified execution #3288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
reviewed
Sep 8, 2025
bolinfest
reviewed
Sep 8, 2025
bolinfest
reviewed
Sep 8, 2025
bolinfest
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job and thanks for the tests!
The only comment I feel strongly about is dropping the use of which
. If the command does not exist, then the process should fail with ENOENT
if we need to treat that case in a special way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified PTY-Based Exec Tool
Note: this requires to have this flag in the config:
use_experimental_unified_exec_tool=true
session_id, bounded output (128 KiB), and timeout clamping (≤ 60 s).
Completions payload while still supported in tool lists.
truncation (truncate_middle).
isolation, timeouts, and truncation behavior.