Skip to content

Update interruption error message styling #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

Update interruption error message styling #3470

merged 3 commits into from
Sep 12, 2025
+5 −4

Conversation

aibrahim-oai
Copy link
Collaborator

@aibrahim-oai aibrahim-oai commented Sep 11, 2025 •
edited
Loading

image image

@edward-bayes
Copy link
Contributor

is spacing between the stop unicode and text the same as elsewhere?

@aibrahim-oai
Copy link
Collaborator Author

@edward-bayes I want to have a separate PR for organizing the alignment because we don't have aligned text everywhere.

nornagon-openai
nornagon-openai requested changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@nornagon-openai nornagon-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think padded_emoji is doing the right thing here; we only want one space after the square.

@aibrahim-oai aibrahim-oai merged commit a2e9cc5 into main Sep 12, 2025
19 checks passed
@aibrahim-oai aibrahim-oai deleted the codex/update-error-strings-to-use-red-symbols branch September 12, 2025 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nornagon-openai nornagon-openai nornagon-openai approved these changes

@edward-bayes edward-bayes Awaiting requested review from edward-bayes

@easong-openai easong-openai Awaiting requested review from easong-openai

Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aibrahim-oai @edward-bayes @nornagon-openai