Skip to content

fix: change MIN_ANIMATION_HEIGHT so show_animation is calculated correctly #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix: change MIN_ANIMATION_HEIGHT so show_animation is calculated correctly #3656

merged 1 commit into from
Sep 15, 2025
+1 −1

Conversation

bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Sep 15, 2025 •
edited
Loading

Reported height was 20 instead of 21, so area.height >= MIN_ANIMATION_HEIGHT was false and therefore show_animation was false, so the animation never displayed.

@ae-openai ae-openai merged commit 0de1541 into main Sep 15, 2025
19 checks passed
@ae-openai ae-openai deleted the pr3656 branch September 15, 2025 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ae-openai ae-openai ae-openai approved these changes

@tibo-openai tibo-openai Awaiting requested review from tibo-openai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bolinfest @ae-openai