Skip to content

Conversation

dedrisian-oai
Copy link
Collaborator

@dedrisian-oai dedrisian-oai commented Sep 20, 2025

Adds the following options:

  1. Review current changes
  2. Review a specific commit
  3. Review against a base branch (PR style)
  4. Custom instructions
Screenshot 2025-09-20 at 2 11 36 PM

+ Adds the following UI helpers:

  1. Makes list selection searchable
  2. Adds navigation to the bottom pane, so you could add a stack of popups
  3. Basic custom prompt view

@aibrahim-oai
Copy link
Collaborator

@codex review this

Copy link
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Copy link
Collaborator

@aibrahim-oai aibrahim-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, amazing functionality. Some points before merging (in order of importance):

  • Scope out view_stack
  • There should be a way to paginate
  • Need to check if it's a git repo or not before rendering those options.
  • If we are introducing search we need to be clear on expectations (we are searching the page not the data)

@dedrisian-oai
Copy link
Collaborator Author

As discussed offline, just moved the commit limit # to 100. Will approach pagination at a different time.

Copy link
Collaborator

@aibrahim-oai aibrahim-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Excited!

@dedrisian-oai dedrisian-oai merged commit 5996ee0 into main Sep 22, 2025
19 checks passed
@dedrisian-oai dedrisian-oai deleted the daniel/review-selector branch September 22, 2025 03:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants