-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: Add more /review options #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@codex review this |
Codex Review: Didn't find any major issues. Chef's kiss. About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, amazing functionality. Some points before merging (in order of importance):
- Scope out
view_stack
- There should be a way to paginate
- Need to check if it's a git repo or not before rendering those options.
- If we are introducing search we need to be clear on expectations (we are searching the page not the data)
As discussed offline, just moved the commit limit # to 100. Will approach pagination at a different time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Excited!
Adds the following options:
+ Adds the following UI helpers: