Add exec output-schema parameter #4079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # codex-rs/core/tests/common/Cargo.toml
… and schema validation
|
@codex review this |
|
Codex Review: Didn't find any major issues. 👍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
aibrahim-oai
approved these changes
Sep 23, 2025
| Some(&serde_json::Value::String("json_schema".into())) | ||
| ); | ||
| assert_eq!(format.get("strict"), Some(&serde_json::Value::Bool(true))); | ||
| assert_eq!(format.get("schema"), Some(&schema)); |
There was a problem hiding this comment.
wdut about serializing it and having one assert_eq function.
There was a problem hiding this comment.
I'd rather have detailed asserts here. Will assert the entire thing in exec tests.
…schema-parameter # Conflicts: # codex-rs/core/src/codex/compact.rs
exec/tests/suite/output_schema.rs: refactor to build schema with serde_json, write as pretty json, and assert full format object equality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds structured output to
execvia the--structured-outputparameter.