Skip to content

Conversation

bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Sep 24, 2025

I am not sure what is going on, as #3660 introduced this new logic and I swear that CI was green before I merged that PR, but I am seeing failures in this CI job this morning. This feels like a non-backwards-compatible change in gh, but that feels unlikely...

Nevertheless, this is what I currently see on my laptop:

$ gh --version
gh version 2.76.2 (2025-07-30)
https://github.com/cli/cli/releases/tag/v2.76.2
$ gh run list --workflow .github/workflows/rust-release.yml --branch rust-v0.40.0 --json workflowName,url,headSha --jq 'first(.[])'
{
  "headSha": "5268705a69713752adcbd8416ef9e84a683f7aa3",
  "url": "https://github.com/openai/codex/actions/runs/17952349351",
  "workflowName": ".github/workflows/rust-release.yml"
}

Looking at sample output from an old GitHub issue (cli/cli#6678), it appears that, at least at one point in time, the workflowName was not the path to the workflow.

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Comment on lines 245 to 253
f"rust-v{version}",
"--json",
"workflowName,url,headSha",
# Empirically, we have seen both "rust-release" and
# ".github/workflows/rust-release.yml" as the workflowName, so we
# check for both here. The docs are not clear on which is expected:
# https://cli.github.com/manual/gh_run_list
"--workflow",
".github/workflows/rust-release.yml",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Account for workflowName path variant in alpha builds

The new --workflow .github/workflows/rust-release.yml logic tolerates the gh run list behavior change when resolving release workflows, but the alpha path still depends on fetch_workflow_url_for_version returning a run whose workflowName equals "rust-release". When the CLI returns .github/workflows/rust-release.yml (the scenario this patch targets), alpha staging still raises "Unable to locate workflow for version …" even though the run exists. Consider applying the same filtering (or checking both names) in fetch_workflow_url_for_version so both release and alpha flows succeed.

Useful? React with 👍 / 👎.

@bolinfest bolinfest merged commit 82e6597 into main Sep 24, 2025
16 checks passed
@bolinfest bolinfest deleted the pr4162 branch September 24, 2025 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants