fix: clean up TypeScript exports #4518
Merged
+38
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
force-pushed
the
pr4518
branch
5 times, most recently
from
6681c8a to
9b958ab
Compare
aibrahim-oai
approved these changes
Sep 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
ExecArbitraryCommandResponsebecause it was missing.use codex_protocol::mcp_protocol::*;to make the file more readable.mcp-typesnow that we have separate the app server from the MCP server: fix: separatecodex mcpintocodex mcp-serverandcodex app-server#4471My next move is to come up with some scheme that ensures request types always have a response type and that the response type is automatically included with the output of
codex generate-ts.