Skip to content

Conversation

pakrym-oai
Copy link
Collaborator

Executable detection uses the same rules as the codex wrapper.

- Remove public "executablePath" from CodexOptions and replace with "@internal" "_executablePathOverride"
- Update Codex to use "_executablePathOverride"
- Refactor all construction sites/tests to use new option
- Enable stripInternal in tsconfig to exclude internal APIs from output
- Simplify jest config, removing unnecessary globals, and consolidate ts-jest ESM config
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

…n options, update usages

- Rename CodexOptions._executablePathOverride to codexExecPathOverride
- Update Codex and tests to use new field name
- Refactor exec.ts variable names for consistency
@pakrym-oai pakrym-oai merged commit 8dd771d into main Oct 1, 2025
20 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/add-executable-detection-and-export-codex-from-the-sdk branch October 1, 2025 01:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants