Update cargo to 2024 edition #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
bolinfest
reviewed
May 7, 2025
| std::env::set_var("OPENAI_REQUEST_MAX_RETRIES", "2"); | ||
| std::env::set_var("OPENAI_STREAM_MAX_RETRIES", "2"); | ||
| // | ||
| // NOTE: Starting with the 2024 edition `std::env::set_var` is `unsafe` |
There was a problem hiding this comment.
I'm a big fan of this change!
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "codex-cli" | |||
| version = { workspace = true } | |||
There was a problem hiding this comment.
outside the scope of this PR, but I guess all of our Cargo.toml files should have version = { workspace = true }?
There was a problem hiding this comment.
Yeah that'd be a bit cleaner
|
Also, can you please rebase past #843 and make sure the |
jcoens-openai
force-pushed
the
dev/jcoens/cargo_update_edition
branch
from
b6cf095 to
6fdb30e
Compare
jcoens-openai
force-pushed
the
dev/jcoens/cargo_update_edition
branch
from
6fdb30e to
8d70a56
Compare
bolinfest
approved these changes
May 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some effects of this change:
set_envare considered unsafe, since this only happens in tests we wrap them inunsafeblocks