Wait for streaming to complete before ending traces in async mode #575
+142
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
onTraceEnd
was called immediately afteronTraceStart
when streaming is enabled, without waiting for the stream loop to complete.Behavior
Before: When
stream: true
,onTraceEnd
was called immediately after therun()
call returned, before spans ended.After: When
stream: true
,onTraceEnd
is called asynchronously after the stream loop completes and all spans have ended. Therun()
call still returns immediately (non-blocking).Closes #570