Skip to content

Ted/move examples to openai cookbook #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

ted-at-openai
Copy link
Collaborator

@ted-at-openai ted-at-openai commented Jul 21, 2022

Primarily, this PR removes the examples from the openai-python library to help keep the library simple and lightweight.

  • Removes all the code examples, and replaces them with short messages link to the new location in OpenAI Cookbook (this way people don't hit annoying 404s if they're following an outside link)
  • Removes the small data files
  • Updates the text and links in the README.md (all links have been doublechecked to work)

Secondly, this PR:

  • Updates numpy requirements due to a vulnerability in 1.21.6
  • Adds api_type to ErrorObject
  • formats the repo with Black (hopefully not too annoying for folks - will likely start to require this in the future, just to keep formatting consistent)

@ted-at-openai ted-at-openai requested a review from hallacy July 21, 2022 00:16
@ted-at-openai
Copy link
Collaborator Author

ted-at-openai commented Jul 21, 2022

@t-asutedjo, recently we decided to move our code examples in the openai-python library to a new home: the OpenAI Cookbook repo.

The goal of this separation is to keep this openai-python library lightweight and dependency-free as we continue to write more and more examples.

I've already copied over your two Azure examples to the OpenAI Cookbook repo (and I'll copy over your latest commit soon).

With the above PR, my plan is to delete your two Azure examples, and replace them with short messages with links to the new OpenAI Cookbook location. Any future changes you want to make to them (or new examples you want to introduce) will be warmly accepted there.

Is that plan ok with you? If not, I'm happy to leave your examples here and/or move them at a later date. Also happy to discuss further. Won't merge this PR until we've had a chance to get on the same page.

@ted-at-openai ted-at-openai force-pushed the ted/move-examples-to-openai-cookbook branch from eed95a9 to b921cfc Compare July 21, 2022 16:27
@t-asutedjo
Copy link
Contributor

@t-asutedjo, recently we decided to move our code examples in the openai-python library to a new home: the OpenAI Cookbook repo.

The goal of this separation is to keep this openai-python library lightweight and dependency-free as we continue to write more and more examples.

I've already copied over your two Azure examples to the OpenAI Cookbook repo (and I'll copy over your latest commit soon).

With the above PR, my plan is to delete your two Azure examples, and replace them with short messages with links to the new OpenAI Cookbook location. Any future changes you want to make to them (or new examples you want to introduce) will be warmly accepted there.

Is that plan ok with you? If not, I'm happy to leave your examples here and/or move them at a later date. Also happy to discuss further. Won't merge this PR until we've had a chance to get on the same page.

That's fine with me, what do you think @sorinsuciu-msft ?

@sorinsuciu-msft
Copy link
Contributor

@t-asutedjo, recently we decided to move our code examples in the openai-python library to a new home: the OpenAI Cookbook repo.
The goal of this separation is to keep this openai-python library lightweight and dependency-free as we continue to write more and more examples.
I've already copied over your two Azure examples to the OpenAI Cookbook repo (and I'll copy over your latest commit soon).
With the above PR, my plan is to delete your two Azure examples, and replace them with short messages with links to the new OpenAI Cookbook location. Any future changes you want to make to them (or new examples you want to introduce) will be warmly accepted there.
Is that plan ok with you? If not, I'm happy to leave your examples here and/or move them at a later date. Also happy to discuss further. Won't merge this PR until we've had a chance to get on the same page.

That's fine with me, what do you think @sorinsuciu-msft ?

HI Ted, yes, we discussed this with Chris already and it's fine from our side.

@hallacy hallacy merged commit 7884a7b into main Jul 26, 2022
@hallacy hallacy deleted the ted/move-examples-to-openai-cookbook branch July 26, 2022 13:35
techthiyanes pushed a commit to techthiyanes/openai-python that referenced this pull request Oct 2, 2023
* Hallacy/pickleable exceptions (openai#109)

* Exceptions in python are hard to pickle.  Make Exceptions pickleable

* Remove debug

* Added tests

* nit

* Change embeddings call to openai.Embedding.create (openai#110)

* Change embeddings call to openai.Embedding.create

* And update model names

* Untweak notebook

* Support encoded embeddings response (openai#111)

* Support encoded embeddings response

* Removed imports

* Add a couple of comments

* Typo

* Remove CA bundle (openai#112)

* Remove CA bundle

* Removed some references
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
* Hallacy/pickleable exceptions (openai#109)

* Exceptions in python are hard to pickle.  Make Exceptions pickleable

* Remove debug

* Added tests

* nit

* Change embeddings call to openai.Embedding.create (openai#110)

* Change embeddings call to openai.Embedding.create

* And update model names

* Untweak notebook

* Support encoded embeddings response (openai#111)

* Support encoded embeddings response

* Removed imports

* Add a couple of comments

* Typo

* Remove CA bundle (openai#112)

* Remove CA bundle

* Removed some references
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
* removes examples (which can now be found in the OpenAI Cookbook repo)

* Update numpy requirements due to vuln in 1.21.6

* adds api_type to ErrorObject

* formats by Black
safa0 pushed a commit to safa0/openai-agents-python that referenced this pull request Apr 27, 2025
Fix streaming in chat completions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants