Adding DASH SAI APIs for load balancer fast path scenario. #1966
Conversation
Signed-off-by: r12f <[email protected]>
| SAI_PORT_STAT_LB_FAST_PATH_ICMP_IN_BYTES = SAI_PORT_STAT_EXTENSIONS_RANGE_START, | ||
|
|
||
| /** DASH port LB_FAST_PATH_ICMP_IN_PACKETS stat count */ | ||
| SAI_PORT_STAT_LB_FAST_PATH_ICMP_IN_PACKETS, |
There was a problem hiding this comment.
is this to count number of icmp_redirect packets, or just icmp packets??
There was a problem hiding this comment.
these counters are specific to LB fast path ICMP packets, not regular ICMP packets or regular ICMP redirect packets that we might not care, e.g. IPv6 ICMP packets with non-zero payload size.
| SAI_PORT_STAT_LB_FAST_PATH_ICMP_IN_PACKETS, | ||
|
|
||
| /** DASH port LB_FAST_PATH_ENI_MISS_BYTES stat count */ | ||
| SAI_PORT_STAT_LB_FAST_PATH_ENI_MISS_BYTES, |
There was a problem hiding this comment.
What do ENI miss bytes indicate?
There was a problem hiding this comment.
There was a problem hiding this comment.
Please confirm if these are DPU level counters. e.g., if a packet if given to a DPU due to PA match, but no ENI match happened once it hits DPU and packet is dropped?
There was a problem hiding this comment.
yes, these are DPU level counters. and yes, it is designed to capture the exact case you are referring to. In this case, nothing will show up on ENI counters. With this counter, we will know what there are valid fast path packets gets dropped, because ENI cannot be found.
|
thanks a lot for the review and approval, Kamil, Sushant and Marian! since we have all parties signed off, I think this change should be ready to merge now. :D |
…teproject#1966) This change adds the SAI API changes for enabling the load balancer fast path scenario. DASH load balancer fast path HLD: https://github.com/sonic-net/DASH/blob/main/documentation/load-bal-service/fast-path-icmp-flow-redirection.md Change that used to generate the headers: [dash-p4] Update DASH BM P4 code for fast path SAI API generation sonic-net/DASH#517 Signed-off-by: r12f <[email protected]>
5 participants
This change adds the SAI API changes for enabling the load balancer fast path scenario.