Skip to content

remove isis_single_topology_required deviation #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

arvbaska1
Copy link
Contributor

remove isis_single_topology_required deviation

@arvbaska1 arvbaska1 requested review from rohit-rp, sudhinj, yunjie-lu and a team as code owners November 29, 2024 22:45
@OpenConfigBot
Copy link

OpenConfigBot commented Nov 29, 2024

Pull Request Functional Test Report for #3616 / 8010a1b

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Cisco 8000E status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Cisco XRd status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Juniper ncPTX status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Nokia SR Linux status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Openconfig Lemming status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Cisco 8808 status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Juniper PTX10008 status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies
Nokia 7250 IXR-10e status
status
status
status
status
RT-4.10: AFTs Route Summary
RT-4.11: AFTs Route Summary
RT-14.2: GRIBI Route Test
TE-17.1: VRF selection policy driven TE
RT-2.1: Base IS-IS Process and Adjacencies

Help

@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 14930377083

Details

  • 10 of 65 (15.38%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 18.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
proto/metadata_go_proto/metadata.pb.go 10 65 15.38%
Totals Coverage Status
Change from base Build 14928400670: -0.03%
Covered Lines: 2481
Relevant Lines: 13766

💛 - Coveralls

self-maurya
self-maurya previously approved these changes Jan 30, 2025
@nikki-blr
Copy link
Contributor

Please resolve the conflicts to get it merged.

@rohit-rp
Copy link
Contributor

rohit-rp commented May 8, 2025

@arvbaska1 Please resolve the conflicts

@arvbaska1
Copy link
Contributor Author

@arvbaska1 Please resolve the conflicts

sure, let me do it eod today

@rohit-rp
Copy link
Contributor

@arvbaska1 I have approved it, but you will have to fix the conflicts yet again, sorry for that. Please ping me directly if you need re-approval after the conflicts are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants