Skip to content

Remove build warning msg with CUDA 10.0 #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2019
Merged

Remove build warning msg with CUDA 10.0 #13596

merged 1 commit into from
Jan 9, 2019

Conversation

nglee
Copy link
Contributor

@nglee nglee commented Jan 8, 2019 •
edited by alalek
Loading

This PR is intended to resolve #13262.

The warning message that says "device_functions.h should not be included directly" seems to be added in CUDA 10.0. It turns out that OpenCV compiles fine without including the header, when tested with CUDA 8.0, 9.0, 9.1, 9.2, 10.0.

buildworker:Custom=linux-1,linux-2,linux-4
force_builders=Custom
docker_image:Custom=ubuntu-cuda:16.04

alalek
alalek approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 4b4874e into opencv:3.4 Jan 9, 2019
opencv-pushbot pushed a commit that referenced this pull request Jan 9, 2019
@alalek
Merge pull request #13596 from nglee:dev_RemoveCudaIncludeWarningMsg
e986ff4
@nglee nglee deleted the dev_RemoveCudaIncludeWarningMsg branch January 10, 2019 00:49
@alalek alalek mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: build/install category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib
Projects
None yet
Milestone
3.4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@nglee @alalek @opencv-pushbot