Skip to content

Conversation

@myhloli
Copy link
Collaborator

@myhloli myhloli commented Dec 15, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copilot AI review requested due to automatic review settings December 15, 2025 10:14
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves content validation and refactors the content list generation logic in the VLM middle JSON content maker. The changes focus on safer dictionary access patterns and code organization.

  • Improved content checking to use safe dictionary access with .get() and filter whitespace-only content
  • Refactored CONTENT_LIST_V2 generation flow by eliminating early continue and restructuring the conditional logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@myhloli myhloli merged commit 6096359 into opendatalab:dev Dec 15, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant