Skip to content

Fix codejail proxy #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix codejail proxy #151

merged 1 commit into from
Feb 1, 2023

Conversation

aht007
Copy link
Contributor

@aht007 aht007 commented Jan 30, 2023

Description

In the latest release of codejail on PyPI, the scripts fail to execute the jailed code because proxy_main isn't packaged correctly. In this PR we moveproxy_main.py inside codejail package and fix the code which makes the call to this file. This PR should potentially fix the codejail release and we should be able to install codejail from PyPI in edx-platform

@aht007 aht007 marked this pull request as draft January 30, 2023 11:43
@aht007 aht007 marked this pull request as ready for review January 31, 2023 07:52
@aht007
Copy link
Contributor Author

aht007 commented Jan 31, 2023

@kdmccormick Can you please review this PR.

@aht007 aht007 requested a review from kdmccormick January 31, 2023 11:04
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two pieces of feedback, up to you whether you use them.

@aht007 aht007 force-pushed the aht007/fix-codejail-proxy branch 2 times, most recently from e67249e to 4d14456 Compare February 1, 2023 07:32
@aht007 aht007 force-pushed the aht007/fix-codejail-proxy branch from 4d14456 to 9b41588 Compare February 1, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants