Skip to content

8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask' #21288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask' #21288

wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 1, 2024 •
edited by openjdk bot
Loading

When running ubsan-enabled optimized binaries on Linux x86_64, test
compiler/startup/StartupOutput.java
triggers this ubsan issue :

jdk/src/hotspot/share/ci/ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask'
    #0 0x7fe7443fc88d in ciEnv::dump_replay_data_helper(outputStream*) src/hotspot/share/ci/ciEnv.cpp:1660
    #1 0x7fe746c22047 in VMError::report_and_die(int, char const*, char const*, __va_list_tag*, Thread*, unsigned char*, void*, void*, char const*, int, unsigned long) src/hotspot/share/utilities/vmError.cpp:1872
    #2 0x7fe7447dd429 in report_fatal(VMErrorType, char const*, int, char const*, ...) src/hotspot/share/utilities/debug.cpp:214
    #3 0x7fe7445c614d in RuntimeStub::new_runtime_stub(char const*, CodeBuffer*, short, int, OopMapSet*, bool, bool) src/hotspot/share/code/codeBlob.cpp:413
    #4 0x7fe744259ceb in Runtime1::generate_blob(BufferBlob*, int, char const*, bool, StubAssemblerCodeGenClosure*) src/hotspot/share/c1/c1_Runtime1.cpp:230
    #5 0x7fe74425a273 in Runtime1::generate_blob_for(BufferBlob*, Runtime1::StubID) src/hotspot/share/c1/c1_Runtime1.cpp:259
    #6 0x7fe74425a273 in Runtime1::initialize(BufferBlob*) src/hotspot/share/c1/c1_Runtime1.cpp:268
    #7 0x7fe743fc04a1 in Compiler::init_c1_runtime() src/hotspot/share/c1/c1_Compiler.cpp:53
    #8 0x7fe743fc04a1 in Compiler::initialize() src/hotspot/share/c1/c1_Compiler.cpp:74
    #9 0x7fe7446aaad7 in CompileBroker::init_compiler_runtime() src/hotspot/share/compiler/compileBroker.cpp:1771
    #10 0x7fe7446b83cf in CompileBroker::compiler_thread_loop() src/hotspot/share/compiler/compileBroker.cpp:1913
    #11 0x7fe74516edca in JavaThread::thread_main_inner() src/hotspot/share/runtime/javaThread.cpp:758
    #12 0x7fe7469d3c9a in Thread::call_run() src/hotspot/share/runtime/thread.cpp:225
    #13 0x7fe746048cd1 in thread_native_entry src/hotspot/os/linux/os_linux.cpp:858
    #14 0x7fe74b1e66e9 in start_thread (/lib64/libpthread.so.0+0xa6e9) (BuildId: 052f7e2a0045f08cb7e7a291f8066a4b7be2521d)
    #15 0x7fe74aaf158e in clone (/lib64/libc.so.6+0x11858e) (BuildId: cfb059a57e69ac95d5dadab831626b3bd48a4309)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask' (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21288/head:pull/21288
$ git checkout pull/21288

Update a local copy of the PR:
$ git checkout pull/21288
$ git pull https://git.openjdk.org/jdk.git pull/21288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21288

View PR using the GUI difftool:
$ git pr show -t 21288

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21288.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024 •
edited
Loading

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask'

Reviewed-by: kvn, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 52c2ea6: 8340732: RISC-V: Refactor crc32 scalar version
  • 90c944f: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()
  • 39c17b3: 8341277: Validate slot argument for instruction factories
  • 0f38113: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base
  • 8d6d37f: 8320308: C2 compilation crashes in LibraryCallKit::inline_unsafe_access
  • 83dcb02: 8340079: Modify rearrange/selectFrom Vector API methods to perform wrapIndexes instead of checkIndexes
  • d2e7708: 8341367: Problemlist ShapeNotSetSometimes.java on macOS
  • 0314973: 8341060: Cleanup statics in HeapDumper
  • 021bf63: 8340458: Open source additional Component tests (part 2)
  • 9a7817b: 8340988: Update jdk/jfr/event/gc/collection tests to accept "CodeCache GC Threshold" as valid GC reason
  • ... and 3 more: https://git.openjdk.org/jdk/compare/684d246ccf497f599ffcd498f2fbe4b1b2357e27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask' 8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask' Oct 1, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

vnkozlov
vnkozlov approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I would say it is trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2024
RealLucy
RealLucy approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MBaesken
Copy link
Member Author

MBaesken commented Oct 2, 2024

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

Going to push as commit efe3573.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 52c2ea6: 8340732: RISC-V: Refactor crc32 scalar version
  • 90c944f: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()
  • 39c17b3: 8341277: Validate slot argument for instruction factories
  • 0f38113: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base
  • 8d6d37f: 8320308: C2 compilation crashes in LibraryCallKit::inline_unsafe_access
  • 83dcb02: 8340079: Modify rearrange/selectFrom Vector API methods to perform wrapIndexes instead of checkIndexes
  • d2e7708: 8341367: Problemlist ShapeNotSetSometimes.java on macOS
  • 0314973: 8341060: Cleanup statics in HeapDumper
  • 021bf63: 8340458: Open source additional Component tests (part 2)
  • 9a7817b: 8340988: Update jdk/jfr/event/gc/collection tests to accept "CodeCache GC Threshold" as valid GC reason
  • ... and 3 more: https://git.openjdk.org/jdk/compare/684d246ccf497f599ffcd498f2fbe4b1b2357e27...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 2, 2024
@openjdk openjdk bot closed this Oct 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@MBaesken Pushed as commit efe3573.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnkozlov vnkozlov vnkozlov approved these changes

@RealLucy RealLucy RealLucy approved these changes

Assignees
No one assigned
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBaesken @vnkozlov @RealLucy