Skip to content

8351876: RISC-V: enable and fix some float round tests #24015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Mar 12, 2025

Hi,
Can you help to review this simple patch?
It's a follow-up of #23985.

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351876: RISC-V: enable and fix some float round tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24015/head:pull/24015
$ git checkout pull/24015

Update a local copy of the PR:
$ git checkout pull/24015
$ git pull https://git.openjdk.org/jdk.git pull/24015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24015

View PR using the GUI difftool:
$ git pr show -t 24015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24015.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2025

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351876: RISC-V: enable and fix some float round tests

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • a33b1f7: 8345298: RISC-V: Add riscv backend for Float16 operations - scalar
  • 6241d09: 8351861: RISC-V: add simple assert at arrays_equals_v
  • 0e7d460: 8351662: [Test] RISC-V: enable bunch of IR test
  • a7ad414: 8351327: -XX:AOTMode=record interferes with application execution
  • 41cc049: 8350840: C2: x64 Assembler::vpcmpeqq assert: failed: XMM register should be 0-15
  • a347ecd: 8350905: Shenandoah: Releasing a WeakHandle's referent may extend its lifetime
  • 5502ce7: 8351699: Problem list com/sun/jdi/JdbStopInNotificationThreadTest.java with ZGC
  • cdf7632: 8351444: Shenandoah: Class Unloading may encounter recycled oops
  • 930455b: 8351640: Print reason for making method not entrant
  • 895f64a: 8351142: Add JFR monitor deflation and statistics events
  • ... and 5 more: https://git.openjdk.org/jdk/compare/3b189e0e78c867b75e984bfaabc92d12b9ff2b9e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2025
@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Mar 12, 2025

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me modulo one minor comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2025
@Hamlin-Li
Copy link
Author

Looks fine to me modulo one minor comment.

Thank you!

@Hamlin-Li
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

Going to push as commit dbf47d6.
Since your change was applied there have been 54 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2025
@openjdk openjdk bot closed this Mar 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@Hamlin-Li Pushed as commit dbf47d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the fix-round-test-failures branch March 18, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants