-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8334247: [PPC64] Consider trap based nmethod entry barriers #24135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8334247: [PPC64] Consider trap based nmethod entry barriers #24135
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@TheRealMDoerr This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@TheRealMDoerr This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@TheRealMDoerr This pull request is now open |
…method_entry_barrier
@TheRealMDoerr This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@TheRealMDoerr The pull request is being re-evaluated and the inactivity timeout has been reset. |
We'll probably get back to this after JDK-8360540 is resolved. |
We can shrink nmethod entry barriers to 4 instructions (from 8) using conditional trap instructions. Some benchmarks seem to show very small improvements. At least the code size reduction is an advantage.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24135/head:pull/24135
$ git checkout pull/24135
Update a local copy of the PR:
$ git checkout pull/24135
$ git pull https://git.openjdk.org/jdk.git pull/24135/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24135
View PR using the GUI difftool:
$ git pr show -t 24135
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24135.diff
Using Webrev
Link to Webrev Comment