Skip to content

8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent #24845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Apr 24, 2025

No need to call List.indexOf(Object) before List.remove(int). Instead we can call List.remove(Object) directly. It's faster and cleaner.
invalidComponents is an ArrayList.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24845/head:pull/24845
$ git checkout pull/24845

Update a local copy of the PR:
$ git checkout pull/24845
$ git pull https://git.openjdk.org/jdk.git pull/24845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24845

View PR using the GUI difftool:
$ git pr show -t 24845

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24845.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2025

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@turbanoff turbanoff changed the title [PATCH] Remove unnecessary List.indexOf key from RepaintManager.removeInvalidComponent [PATCH] Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent Apr 24, 2025
invalidComponents.remove(index);
}
if (invalidComponents != null) {
invalidComponents.remove(component);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the addInvalidComponent above can be simplified as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified how?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the loop over invalidComponents

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you suggest to use List.indexOf instead of manual loop?

int n = invalidComponents.size();
for(int i = 0; i < n; i++) {
if(validateRoot == invalidComponents.get(i)) {
return;
}
}

This loop uses == comparison, while List.indexOf uses equals(). It could change semantic

Copy link
Member

@mrserb mrserb May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then it is fine as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet there could be a logical error anyway… addInvalidComponent uses identity comparison when adding a component but removeInvalidComponent relies on equals method to remove a component.

If a component overrides equals, it could lead to unpredictable behaviour: a wrong component could be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's better to use "==" in all cases, what do you think?

Copy link
Member Author

@turbanoff turbanoff Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filled JDK-8361493

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Andrey.

P.S. The link is broken, it doesn't lead to the JBS issue.

@turbanoff turbanoff changed the title [PATCH] Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent 8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent May 19, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2025
@mlbridge
Copy link

mlbridge bot commented May 19, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants