8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent

[turbanoff]

No need to call List.indexOf(Object) before List.remove(int). Instead we can call List.remove(Object) directly. It's faster and cleaner.
invalidComponents is an ArrayList.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24845/head:pull/24845
$ git checkout pull/24845

Update a local copy of the PR:
$ git checkout pull/24845
$ git pull https://git.openjdk.org/jdk.git pull/24845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24845

View PR using the GUI difftool:
$ git pr show -t 24845

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24845.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

I guess the addInvalidComponent above can be simplified as well?

[turbanoff]

Simplified how?

[mrserb]

the loop over invalidComponents

[turbanoff]

Do you suggest to use List.indexOf instead of manual loop?

jdk/src/java.desktop/share/classes/javax/swing/RepaintManager.java

Lines 366 to 371 in 375ac6d

	int n = invalidComponents.size();
	for(int i = 0; i < n; i++) {
	if(validateRoot == invalidComponents.get(i)) {
	return;
	}
	}

This loop uses == comparison, while List.indexOf uses equals(). It could change semantic

[mrserb]

ok, then it is fine as is.

[aivanov-jdk]

Yet there could be a logical error anyway… addInvalidComponent uses identity comparison when adding a component but removeInvalidComponent relies on equals method to remove a component.

If a component overrides equals, it could lead to unpredictable behaviour: a wrong component could be removed.

[mrserb]

Then it's better to use "==" in all cases, what do you think?

[turbanoff]

Filled JDK-8361493

[aivanov-jdk]

Thank you, Andrey.

P.S. The link is broken, it doesn't lead to the JBS issue.

[mlbridge]

Webrevs

• 00: Full (a623bab6)

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!