-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent #24845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent #24845
Conversation
…eInvalidComponent
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
invalidComponents.remove(index); | ||
} | ||
if (invalidComponents != null) { | ||
invalidComponents.remove(component); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the addInvalidComponent
above can be simplified as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified how?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the loop over invalidComponents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest to use List.indexOf
instead of manual loop?
jdk/src/java.desktop/share/classes/javax/swing/RepaintManager.java
Lines 366 to 371 in 375ac6d
int n = invalidComponents.size(); | |
for(int i = 0; i < n; i++) { | |
if(validateRoot == invalidComponents.get(i)) { | |
return; | |
} | |
} |
This loop uses ==
comparison, while List.indexOf
uses equals()
. It could change semantic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, then it is fine as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet there could be a logical error anyway… addInvalidComponent
uses identity comparison when adding a component but removeInvalidComponent
relies on equals
method to remove a component.
If a component overrides equals
, it could lead to unpredictable behaviour: a wrong component could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's better to use "==" in all cases, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filled JDK-8361493
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Andrey.
P.S. The link is broken, it doesn't lead to the JBS issue.
@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
No need to call
List.indexOf(Object)
beforeList.remove(int)
. Instead we can callList.remove(Object)
directly. It's faster and cleaner.invalidComponents
is an ArrayList.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24845/head:pull/24845
$ git checkout pull/24845
Update a local copy of the PR:
$ git checkout pull/24845
$ git pull https://git.openjdk.org/jdk.git pull/24845/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24845
View PR using the GUI difftool:
$ git pr show -t 24845
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24845.diff
Using Webrev
Link to Webrev Comment