8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError #26122

dholmes-ora · 2025-07-03T22:11:55Z

In JDK-8186092 (way back in JDK 10) we elided loader constraint checks for overpass methods related to default methods by skipping them when initializing the itable for the interface. But that was the wrong place to do that. The overpass method is setup when there is a resolution/selection error so that the correct exception is thrown if the problematic method is invoked (like the ICCE reporting conflicting methods) and by eliding that entry we instead get the AbstractMethhodError.

The fix here is to revert that change from JDK-8186092, and to address the loader constraint problem by adding the same check for overpass methods in klassItable::check_constraints that exists for klassVtable::check_constraints.

Testing:

modified existing regression test
tiers 1-4

EDIT: originally there was a new regression test for this, but this area is already covered by the vmTestBase "defmeth tests. That test was missing the necessary invocation modes to expose the bug, so they have been added.

Thanks

PS. The diff is much smaller if you disable whitespace differences.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Warning

⚠️ Found leading lowercase letter in issue title for 8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError

Issue

JDK-8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError (Bug - P3)

Reviewers

Coleen Phillimore (@coleenp - Reviewer)
Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26122/head:pull/26122
$ git checkout pull/26122

Update a local copy of the PR:
$ git checkout pull/26122
$ git pull https://git.openjdk.org/jdk.git pull/26122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26122

View PR using the GUI difftool:
$ git pr show -t 26122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26122.diff

Using Webrev

Link to Webrev Comment

…atibleClassChangeError

bridgekeeper · 2025-07-03T22:12:22Z

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-07-03T22:12:40Z

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError

Reviewed-by: coleenp, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 229 new commits pushed to the master branch:

5cf672e: 8359053: Implement JEP 504 - Remove the Applet API
a10ee46: 8361224: [macos] MacSignTest.testMultipleCertificates failed
6cff49c: 8361380: ARM32: Atomic stubs should be in pre-universe
... and 226 more: https://git.openjdk.org/jdk/compare/ba0c12231b0f5b680951e75765b5d292f31a2cbc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-07-03T22:13:18Z

@dholmes-ora The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

dholmes-ora · 2025-07-03T22:16:35Z

/label add hotspot-runtime

openjdk · 2025-07-03T22:16:45Z

@dholmes-ora
The hotspot-runtime label was successfully added.

mlbridge · 2025-07-03T22:20:31Z

Webrevs

…the invokeinterface variants of the test scenario. Also updated all tests therein to use `throwsExact` so that the wrong kind of ICCE does not cause the test to pass by mistake.

test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/ConflictingDefaultsTest.java

coleenp

Still so many questions...

src/hotspot/share/oops/klassVtable.cpp

coleenp

Looks good.

src/hotspot/share/oops/klassVtable.cpp

test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/ConflictingDefaultsTest.java

dholmes-ora · 2025-07-10T01:56:27Z

Thanks for the review @coleenp !

iklam

The changes look reasonable to me.

dholmes-ora · 2025-07-14T22:52:47Z

Thanks for the review @iklam !

/integrate

openjdk · 2025-07-14T22:53:48Z

Going to push as commit f36147b.
Since your change was applied there have been 229 commits pushed to the master branch:

5cf672e: 8359053: Implement JEP 504 - Remove the Applet API
a10ee46: 8361224: [macos] MacSignTest.testMultipleCertificates failed
6cff49c: 8361380: ARM32: Atomic stubs should be in pre-universe
... and 226 more: https://git.openjdk.org/jdk/compare/ba0c12231b0f5b680951e75765b5d292f31a2cbc...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-07-14T22:53:58Z

@dholmes-ora Pushed as commit f36147b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

dholmes-ora · 2025-07-15T00:18:13Z

/backport jdk jdk25

openjdk · 2025-07-15T00:19:24Z

@dholmes-ora the backport was successfully created on the branch backport-dholmes-ora-f36147b3-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f36147b3 from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 14 Jul 2025 and was reviewed by Coleen Phillimore and Ioi Lam.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-dholmes-ora-f36147b3-jdk25:backport-dholmes-ora-f36147b3-jdk25
$ git checkout backport-dholmes-ora-f36147b3-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-dholmes-ora-f36147b3-jdk25

dholmes-ora added 2 commits July 3, 2025 01:26

8356942: invokeinterface Throws AbstractMethodError Instead of Incomp…

13744cd

…atibleClassChangeError

regression test

5e49c49

openjdk bot added the rfr Pull request is ready for review label Jul 3, 2025

openjdk bot added the hotspot [email protected] label Jul 3, 2025

dholmes-ora changed the title ~~8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError~~ 8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError Jul 3, 2025

openjdk bot added the hotspot-runtime [email protected] label Jul 3, 2025

Replaced new test by updating existing defmeth case that was missing …

2988354

…the invokeinterface variants of the test scenario. Also updated all tests therein to use `throwsExact` so that the wrong kind of ICCE does not cause the test to pass by mistake.

coleenp reviewed Jul 8, 2025

View reviewed changes

test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/ConflictingDefaultsTest.java Show resolved Hide resolved

coleenp reviewed Jul 8, 2025

View reviewed changes

src/hotspot/share/oops/klassVtable.cpp Outdated Show resolved Hide resolved

src/hotspot/share/oops/klassVtable.cpp Show resolved Hide resolved

Fix weird logic - requested by Coleen

d12213e

coleenp approved these changes Jul 8, 2025

View reviewed changes

src/hotspot/share/oops/klassVtable.cpp Show resolved Hide resolved

test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/ConflictingDefaultsTest.java Show resolved Hide resolved

openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025

iklam approved these changes Jul 14, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jul 14, 2025

openjdk bot closed this Jul 14, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2025

dholmes-ora deleted the 8356942-invokeintf branch July 15, 2025 00:17

8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError #26122

8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError #26122

Conversation

dholmes-ora commented Jul 3, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Warning

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 3, 2025

Uh oh!

openjdk bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jul 3, 2025

Uh oh!

dholmes-ora commented Jul 3, 2025

Uh oh!

openjdk bot commented Jul 3, 2025

Uh oh!

mlbridge bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

coleenp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coleenp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dholmes-ora commented Jul 10, 2025

Uh oh!

iklam left a comment

Choose a reason for hiding this comment

Uh oh!

dholmes-ora commented Jul 14, 2025

Uh oh!

openjdk bot commented Jul 14, 2025

Uh oh!

openjdk bot commented Jul 14, 2025

Uh oh!

dholmes-ora commented Jul 15, 2025

Uh oh!

openjdk bot commented Jul 15, 2025

Uh oh!

Uh oh!

dholmes-ora commented Jul 3, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jul 3, 2025 •

edited

Loading

mlbridge bot commented Jul 3, 2025 •

edited

Loading