8361417: JVMCI getModifiers incorrect for inner classes

[dougxc]

The result of ResolvedJavaType.getModifiers() should always have been the same as Class.getModifiers(). This is currently not the case for inner classes. Instead, the value is derived from Klass::_access_flags where as it should be derived from the InnerClasses attribute (as it is for Class).

This PR aligns ResolvedJavaType.getModifiers() with Class.getModifiers().

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361417: JVMCI getModifiers incorrect for inner classes (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26135/head:pull/26135
$ git checkout pull/26135

Update a local copy of the PR:
$ git checkout pull/26135
$ git pull https://git.openjdk.org/jdk.git pull/26135/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26135

View PR using the GUI difftool:
$ git pr show -t 26135

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26135.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d8dfc582)

[dougxc]

I've converted this to draft as it no longer clear that JVMCI should follow core reflection in the specific case of ResolvedJavaType.getModifiers().