Skip to content

8361449: RISC-V: Code cleanup for native call #26150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jul 7, 2025

Hi, please consider this code cleanup change for native call.

This removes the address parameter for NativeCall::reloc_destination and NativeFarCall::reloc_destination.
This also removes several unnecessary code blob related runtime checks turning them into assertions.

Testing

  • hs:tier1 - hs:tier3 tested with linux-riscv64 fastdebug build

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361449: RISC-V: Code cleanup for native call (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26150/head:pull/26150
$ git checkout pull/26150

Update a local copy of the PR:
$ git checkout pull/26150
$ git pull https://git.openjdk.org/jdk.git pull/26150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26150

View PR using the GUI difftool:
$ git pr show -t 26150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26150.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@DingliZhang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025

Webrevs

@DingliZhang
Copy link
Member Author

Hi @robehn , could you help to review this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant