-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361478: GHA: Use MSYS2 from GHA runners #26156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
I recall there were some issues with using MSYS2 that comes with Actions. That was a long time ago though, are they no longer a problem with current Actions and MSYS2 versions? |
We used to have a problem building jtreg, so we pinned and later unpinned the version: JDK-8310259. But today, we do not build jtreg on Windows at all. And we have not seen any issues with MSYS2 since. So I think it is okay to bump the version now. We can retract it back if we find problems, it would only require rewiring the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem was something else about Actions MSYS2 not being usable, but alas I can't remember enough to actually make a valid point. So this gets a +1 from me since it can easily be backed out if it does cause issues. I'm not a Reviewer though, so you'll have to wait for Magnus to take a look at this
Hey @magicus ;) |
Installing MSYS2 takes considerable time in our Windows workflows. Fortunately, GHA runners currently ship with MSYS2 bundled! The docs for setup-msys2 step say it is enough to say
release: false
to use those:https://github.com/msys2/setup-msys2?tab=readme-ov-file#release
Also bumping the action version to gain access to the actual installed path.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26156/head:pull/26156
$ git checkout pull/26156
Update a local copy of the PR:
$ git checkout pull/26156
$ git pull https://git.openjdk.org/jdk.git pull/26156/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26156
View PR using the GUI difftool:
$ git pr show -t 26156
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26156.diff
Using Webrev
Link to Webrev Comment