-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360647: [XWayland] [OL10] NumPad keys are not triggered #26170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Will Java receive the same keycodes if these events come from native code? |
Yes, java receives the same events for both remote desktop emulated keystrokes and physical keystrokes, whether NumLock is on or off. |
The test expects to receive Insert (not 0) even if numlock is on ? Why is that ? It isn't really mentioned but this about Robot, isn't it ? Can you please put an evaluation in the bug report. |
The test doesn't care which button is pressed. It stores the keyCode-keyChar pair in a map received from the keyPressed event. jdk/test/jdk/java/awt/event/KeyEvent/KeyCharTest/KeyCharTest.java Lines 45 to 55 in 518536c
Before the fix, it was receiving:
After the fix, everything is consistent, and the same key events are reported as if they were pressed by a user.
Sure.
Yes, it is. |
@azvegint This is in regards to the regression test for this fix. The existing test To better replicate the problem without the fix, adding a new test for this changeset might be a good idea.
|
When we try to pass
XK_KP_0
toNotifyKeyboardKeysym
in Remote Desktop API, it presses/releasesSHIFT
+XK_KP_Insert
.To get the same result as XTest api when using
NotifyKeyboardKeysym
we should useXK_KP_Insert
instead ofXK_KP_0
regardless of NumLock state. Similarly for other Numpad keys.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26170/head:pull/26170
$ git checkout pull/26170
Update a local copy of the PR:
$ git checkout pull/26170
$ git pull https://git.openjdk.org/jdk.git pull/26170/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26170
View PR using the GUI difftool:
$ git pr show -t 26170
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26170.diff
Using Webrev
Link to Webrev Comment