Skip to content

8361639: JFR: Incorrect top frame for I/O events #26211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jul 9, 2025

Could I have a review of the change that ensures that the top frame for I/O events is not an internal JDK method, such as FileReadEvent::offer?

Testing: tier1 + jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361639: JFR: Incorrect top frame for I/O events (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26211/head:pull/26211
$ git checkout pull/26211

Update a local copy of the PR:
$ git checkout pull/26211
$ git pull https://git.openjdk.org/jdk.git pull/26211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26211

View PR using the GUI difftool:
$ git pr show -t 26211

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26211.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@egahlin The following labels will be automatically applied to this pull request:

  • hotspot-jfr
  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

testFileWrite();
testFileRead();
testSocketStreams();
testSocketChannels();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other case is the socket adaptor, as in SocketChannel::socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants