8361639: JFR: Incorrect top frame for I/O events #26211
Draft
+305
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could I have a review of the change that ensures that the top frame for I/O events is not an internal JDK method, such as FileReadEvent::offer?
Testing: tier1 + jdk/jdk/jfr
Thanks
Erik
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26211/head:pull/26211
$ git checkout pull/26211
Update a local copy of the PR:
$ git checkout pull/26211
$ git pull https://git.openjdk.org/jdk.git pull/26211/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26211
View PR using the GUI difftool:
$ git pr show -t 26211
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26211.diff