8361314: Test serviceability/jvmti/VMEvent/MyPackage/VMEventRecursionTest.java FATAL ERROR in native method: Failed during the GetClassSignature call

[alexmenkov]

The fix adds guards against JVMTI_ERROR_WRONG_PHASE error in VMObjectAlloc event handler.

Testing: fixed test on all platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361314: Test serviceability/jvmti/VMEvent/MyPackage/VMEventRecursionTest.java FATAL ERROR in native method: Failed during the GetClassSignature call (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26231/head:pull/26231
$ git checkout pull/26231

Update a local copy of the PR:
$ git checkout pull/26231
$ git pull https://git.openjdk.org/jdk.git pull/26231/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26231

View PR using the GUI difftool:
$ git pr show -t 26231

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26231.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361314: Test serviceability/jvmti/VMEvent/MyPackage/VMEventRecursionTest.java FATAL ERROR in native method: Failed during the GetClassSignature call

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 2e7e272: 8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb
• ee0d309: 8313395: LotsUnloadTest.java fails with OOME transiently with libgraal
• 2300a21: 8358679: [asan] vmTestbase/nsk/jvmti tests show memory issues
• ... and 37 more: https://git.openjdk.org/jdk/compare/974ad4e8cdddee7d932e8375258067f9d2ca6a8b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (96b58f1e)

[plummercj]

Your changes look fine, but I'm a bit confused as to how this test is testing for what it claims it is testing:

Verifies that a VM event callback does not recurse if a VM object is allocated during callback.

Where is it actually checking that it is not recursing?

[alexmenkov]

Your changes look fine, but I'm a bit confused as to how this test is testing for what it claims it is testing:

Verifies that a VM event callback does not recurse if a VM object is allocated during callback.

Where is it actually checking that it is not recursing?

VMObjectAlloc callback does upcall (clone) which does new allocation.
So if the recursion happen, the test gets infinite recursion

[plummercj]

VMObjectAlloc callback does upcall (clone) which does new allocation.
So if the recursion happen, the test gets infinite recursion

Ok, so the failure then will be a StackOverflowException.

[sspitsyn]

Looks good.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 8c00c37.
Since your change was applied there have been 47 commits pushed to the master branch:

• 59bec29: 8358580: Rethink how classes are kept alive in training data
• a86dd56: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435
• 76442f3: 8361494: [IR Framework] Escape too much in replacement of placeholder
• ... and 44 more: https://git.openjdk.org/jdk/compare/974ad4e8cdddee7d932e8375258067f9d2ca6a8b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 8c00c37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.