test: use branch/alias deploys for e2e test suite to enable automatic deploy cleanup #2752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
force-pushed
the
use-branch-deploys-in-e2e-tests
branch
2 times, most recently
from
c5dd3a1 to
42b9342
Compare
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
force-pushed
the
use-branch-deploys-in-e2e-tests
branch
from
ef8593a to
1700831
Compare
mrstork
force-pushed
the
use-branch-deploys-in-e2e-tests
branch
from
7bd56b5 to
41b9eb6
Compare
mrstork
force-pushed
the
use-branch-deploys-in-e2e-tests
branch
from
7d3a358 to
ac580e6
Compare
mrstork
force-pushed
the
use-branch-deploys-in-e2e-tests
branch
from
2d4bc38 to
f0e2da0
Compare
pieh
previously approved these changes
Jan 29, 2025
mrstork
force-pushed
the
use-branch-deploys-in-e2e-tests
branch
from
ed242e8 to
4dae38d
Compare
pieh
reviewed
Jan 30, 2025
Comment on lines
+56
to
+59
| // on Node 18.20.6 on Windows, there seems to be an issue with OG image generation in this scenario | ||
| // that is reproducible with `next start` even outside of Netlify context | ||
| test.skipIf(platform === 'win32')<FixtureTestContext>( | ||
| 'should work in app route with node runtime', |
There was a problem hiding this comment.
Unrelated to rest of PR, but to not create separate change throwing it here
Showing same kind of error we see in github action logs https://github.com/opennextjs/opennextjs-netlify/actions/runs/13055953386/job/36426974015?pr=2752#step:12:557
⨯ [Error: failed to pipe response] {
[cause]: TypeError: Invalid URL
at async Object.start (D:\a\opennextjs-netlify\opennextjs-netlify-dist07klBn\___netlify-server-handler\.next\server\app\og-node\route.js:2:25299) {
input: '.\\file:\\D:\\a\\opennextjs-netlify\\opennextjs-netlify-dist07klBn\\___netlify-server-handler\\node_modules\\next\\dist\\compiled\\@vercel\\og\\noto-sans-v27-latin-regular.ttf',
code: 'ERR_INVALID_URL'
}
}
using just pure Next.js:
This was not happening on 18.20.5, so I suspect nodejs/node@da2d177f91 being source of this problem, but this looks like something that should be fixed/addressed in Next.js as we don't do anything specific for OG images in the area where failure is happening (failing to load a font?)
pieh
approved these changes
Jan 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy previews aren't currently subject to the same retention policy as regular deploys, as such we end up keeping our test runs around for longer than we intend. Switching to branch deploys (i.e. giving all test runs the
next-e2e-testsalias) allows them to be picked up by the daily soft deletion worker.Before: Deploy Preview
After: Branch Deploy